Differential D13927

autotests: Compare doubles to doubles
ClosedPublic
Actions

Authored by zzag on Jul 6 2018, 8:32 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R110:03aed13d9ff3: Fix unit tests for Qt5.9: QCOMPARE has no overload for double vs. int
Summary

That's not possible to compare doubles to ints with QCOMPARE in Qt 5.9.

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 6 2018, 8:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 6 2018, 8:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Jul 6 2018, 8:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2018, 8:41 PM
Closed by commit R110:03aed13d9ff3: Fix unit tests for Qt5.9: QCOMPARE has no overload for double vs. int (authored by kossebau). · Explain Why
This revision was automatically updated to reflect the committed changes.
kossebau added a subscriber: kossebau.EditedJul 6 2018, 8:43 PM

Pardon for having pushed a fix directly, as I was sure about this fix for the issue :) (Edit: and I had not seen this review request).
Seems Phabricator decided it's the same commit due to being an identical patch?

zzag added a comment.Jul 6 2018, 8:49 PM

Seems Phabricator decided it's the same commit due to being an identical patch?

I guess so.

davidedmundson added a subscriber: davidedmundson.Jul 7 2018, 8:53 AM

My fault :/
Thanks for taking care of that.

Revision Contents
Changeset List

PathPackages
Mautotests/testkwaylandconfig.cpp (6 lines)

Diff 37278

View Options

autotests/testkwaylandconfig.cpp

Loading...