Differential D13897

Refactor udsentrytest
ClosedPublic
Actions

Authored by jtamate on Jul 5 2018, 8:15 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:d24a61cae282: Refactor udsentrytest
Summary

Use c++ initialization lists instead of <<.
Or in other words, apply https://www.angrycane.com.br/en/2018/06/19/speeding-up-cornercases/

Test Plan

The test passes.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Jul 5 2018, 8:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 5 2018, 8:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jtamate requested review of this revision.Jul 5 2018, 8:15 AM
dfaure added a comment.Jul 5 2018, 10:55 AM

I'm not a big fan of the comma at the beginning of the line (without even a space after the comma). Why not at end of line? I guess search-replace made this way easier, but it doesn't really look good ;)
Try kde-dev-scripts's uncrustify script, it might reformat all this correctly ;)

jtamate updated this revision to Diff 37183.Jul 5 2018, 11:37 AM

Commas at the end.

dfaure accepted this revision.Jul 5 2018, 12:57 PM
This revision is now accepted and ready to land.Jul 5 2018, 12:57 PM
Closed by commit R241:d24a61cae282: Refactor udsentrytest (authored by jtamate). · Explain WhyJul 5 2018, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/udsentrytest.cpp (150 lines)

Diff 37199

View Options

autotests/udsentrytest.cpp

Loading...