Fix opening tar.foo.N archives
ClosedPublic
Actions

Authored by elvisangelaccio on Apr 11 2016, 10:34 AM.

Details

Reviewers

Commits

R36:27be88baaa25: Fix opening tar archives whose name ends with a number

Summary

Tar archives whose extension is something like tar.gz.1 will be opened by the
singlefile plugin. It seems wget can create this kind of filenames.

This patch extends the input validation we already do for tar archives, to
also cover this case.

(Bugfix meant for Applications/16.04 branch)

Test Plan

a test case is added in the mimetype tests.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 3275.Apr 11 2016, 10:34 AM

elvisangelaccio retitled this revision from to Fix opening tar.foo.N archives Tar archives whose extension is something like `tar.gz.1` will be opened by the singlefile plugin. It seems wget can create this kind of filenames. This patch extends the input validation we already do for tar....

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptApr 11 2016, 10:34 AM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

elvisangelaccio retitled this revision from Fix opening tar.foo.N archives Tar archives whose extension is something like `tar.gz.1` will be opened by the singlefile plugin. It seems wget can create this kind of filenames. This patch extends the input validation we already do for tar... to Fix opening tar.foo.N archives .Apr 11 2016, 10:36 AM

elvisangelaccio updated this object.

works for me :)