Differential D1384

Fix opening tar.foo.N archives
ClosedPublic
Actions

Authored by elvisangelaccio on Apr 11 2016, 10:34 AM.

Details

Reviewers
rthomsen
Commits
R36:27be88baaa25: Fix opening tar archives whose name ends with a number
Summary

Tar archives whose extension is something like tar.gz.1 will be opened by the
singlefile plugin. It seems wget can create this kind of filenames.

This patch extends the input validation we already do for tar archives, to
also cover this case.

(Bugfix meant for Applications/16.04 branch)

Test Plan

a test case is added in the mimetype tests.

Diff Detail

Repository
R36 Ark
Branch
fix-wrong-tar-extension
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 3275.Apr 11 2016, 10:34 AM
elvisangelaccio retitled this revision from to Fix opening tar.foo.N archives Tar archives whose extension is something like `tar.gz.1` will be opened by the singlefile plugin. It seems wget can create this kind of filenames. This patch extends the input validation we already do for tar....
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptApr 11 2016, 10:34 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
elvisangelaccio retitled this revision from Fix opening tar.foo.N archives Tar archives whose extension is something like `tar.gz.1` will be opened by the singlefile plugin. It seems wget can create this kind of filenames. This patch extends the input validation we already do for tar... to Fix opening tar.foo.N archives .Apr 11 2016, 10:36 AM
elvisangelaccio updated this object.
rthomsen accepted this revision.Apr 23 2016, 12:14 PM
rthomsen edited edge metadata.

works for me :)

kerfuffle/mimetypes.cpp
51

Would you mind writing in the comment what is done here? It's really hard to follow...

This revision is now accepted and ready to land.Apr 23 2016, 12:14 PM
elvisangelaccio marked an inline comment as done.Apr 23 2016, 2:09 PM

Revision Contents
Changeset List

Diff 3275

View Options

autotests/kerfuffle/data/wget-download.tar.gz.1

Loading...
View Options

autotests/kerfuffle/mimetypetest.cpp

Loading...
View Options

kerfuffle/mimetypes.cpp

Loading...