[Places Runner] Fix opening search and timeline URLs
ClosedPublic

Authored by broulik on Jul 2 2018, 8:58 AM.

Details

Summary

KFilePlacesModel internally only stores search:/ URLs and then translates them to the correct Baloo query as needed.

Test Plan

This method was added in KF 5.41 according to docs, so this can go into Plasma 5.12 which depends on 5.42 according to wiki

It's still a bit awkward that you get two "Pictures" results, one being the "Search for Pictures" and the other the "Pictures" folder but at least you can open both of them correctly now.

I'll see if I can maybe add the group name as subText so it looks like "Pictures (Search For)", but it might also add "Places: Pictures (Places)" which is a bit weird

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 2 2018, 8:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 2 2018, 8:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 2 2018, 8:58 AM
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jul 2 2018, 9:00 AM
This revision is now accepted and ready to land.Jul 2 2018, 9:00 AM
This revision was automatically updated to reflect the committed changes.