Differential D13836

Use std::find_if in EffectsHandlerImpl::isEffectLoaded
ClosedPublic
Actions

Authored by zzag on Jul 2 2018, 7:56 AM.

Details

Reviewers
broulik
romangg
Group Reviewers
KWin
Commits
R108:7ee83dc5e425: Use std::find_if in EffectsHandlerImpl::isEffectLoaded
Summary

Don't use raw loops. Use appropriate algorithm from STL to find out
whether effect with the given name is loaded.

(also, this change deletes duplicated logic)

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 2 2018, 7:56 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 2 2018, 7:56 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 2 2018, 7:56 AM
broulik added a subscriber: broulik.Jul 2 2018, 9:10 AM
broulik added inline comments.
effects.cpp
1373

Capture &name by reference

zzag updated this revision to Diff 37041.Jul 2 2018, 9:44 AM

Capture by reference.

zzag marked an inline comment as done.Jul 2 2018, 9:44 AM
broulik accepted this revision.Jul 3 2018, 7:09 AM
This revision is now accepted and ready to land.Jul 3 2018, 7:09 AM
romangg accepted this revision.Jul 3 2018, 7:45 AM
Closed by commit R108:7ee83dc5e425: Use std::find_if in EffectsHandlerImpl::isEffectLoaded (authored by zzag). · Explain WhyJul 3 2018, 9:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects.cpp (15 lines)

Diff 37095

View Options

effects.cpp

Loading...