[libkwineffects] Push render targets more efficiently in GLRenderTarget::pushRenderTargets
ClosedPublic

Authored by zzag on Jul 1 2018, 11:03 AM.

Details

Summary

If s_renderTargets is not empty, GLRenderTarget::pushRenderTargets starts
to do pretty heavy things: it deletes head of the targets param in a while loop.

There is no need to do that. Because QStack inherits QVector, we can use
append method to push new render targets in a more efficient way.

Test Plan

Background behind Konsole is still blurred.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 1 2018, 11:03 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 1 2018, 11:03 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 1 2018, 11:03 AM
mart accepted this revision.Jul 2 2018, 11:15 AM
This revision is now accepted and ready to land.Jul 2 2018, 11:15 AM
This revision was automatically updated to reflect the committed changes.