Touchpad KCM Pointer Speed Slider Improvement
ClosedPublic

Authored by furkantokac on Jun 27 2018, 7:18 PM.

Details

Summary

Slider value to libinput value mapping algorithm is changed. Tested and everything is working fine.
You can test it by changing value on slider and checking the libinput value from ~/.config/kcminputrc
UI is same so I don't share screenshot.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
furkantokac created this revision.Jun 27 2018, 7:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 27 2018, 7:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
furkantokac requested review of this revision.Jun 27 2018, 7:18 PM
furkantokac edited the summary of this revision. (Show Details)Jun 27 2018, 7:20 PM
furkantokac added reviewers: ngraham, romangg, Plasma.
ngraham requested changes to this revision.Jun 27 2018, 7:26 PM

Almost perfect, just one issue below:

kcms/touchpad/src/kcm/libinput/main.qml
239

Let's do this in a separate commit where we change it along with the same value in the Mouse KCM.

This revision now requires changes to proceed.Jun 27 2018, 7:26 PM
furkantokac added inline comments.Jun 27 2018, 7:39 PM
kcms/touchpad/src/kcm/libinput/main.qml
239

Sure it will be better. Thanks!

"value" part of last "Slider" patch is reverted since that kind of changes will be handled with another patch.

ngraham accepted this revision.Jun 27 2018, 7:48 PM

FWIW, you can mark those comments as done.

This revision is now accepted and ready to land.Jun 27 2018, 7:48 PM
furkantokac marked 2 inline comments as done.Jun 27 2018, 8:36 PM
romangg added inline comments.Jun 27 2018, 9:27 PM
kcms/touchpad/src/kcm/libinput/main.qml
247–248

range [1, 11]

romangg accepted this revision.Jun 27 2018, 9:28 PM

Comment correction.

This revision was automatically updated to reflect the committed changes.