Differential D13719

OdfExtractor: deal with non-common prefix names
ClosedPublic
Actions

Authored by kossebau on Jun 25 2018, 1:56 PM.

Details

Reviewers
vandenoever
Commits
R286:fd3319a6803b: OdfExtractor: deal with non-common prefix names
Test Plan

Autotest odfextractortest still works.

Diff Detail

Repository
R286 KFileMetaData
Branch
noncommonprefixodf
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 301
Build 301: arc lint + arc unit
kossebau created this revision.Jun 25 2018, 1:56 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 25 2018, 1:56 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jun 25 2018, 1:56 PM
vandenoever accepted this revision.Jun 25 2018, 5:30 PM

Good fixes. Just some small naming suggestions.

src/extractors/odfextractor.cpp
37 ↗(On Diff #36637)

Perhaps name this elementByTagNameNS.

39 ↗(On Diff #36637)

Variable name e for element is more logical.

This revision is now accepted and ready to land.Jun 25 2018, 5:30 PM
kossebau updated this revision to Diff 36647.Jun 25 2018, 6:01 PM

Update to Jos' feedback (thanks for that)

Using "firstChildElementNS" as name for the method, so it's closer to
QDomNode API and more telling what it does

If no-one has further comments, would commit on Wednesday.

Closed by commit R286:fd3319a6803b: OdfExtractor: deal with non-common prefix names (authored by kossebau). · Explain WhyJun 27 2018, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/odfextractor.cpp (94 lines)

Diff 36647

View Options

src/extractors/odfextractor.cpp

Loading...