pykrita: expose the real i18n() function
ClosedPublic
Actions

Authored by pino on Jun 23 2018, 8:53 AM.

Details

Reviewers

Group Reviewers

Commits

R37:575912219f83: pykrita: expose the real i18n() function
R37:11157ddd1ac6: pykrita: expose the real i18n() function
R37:b7b398897132: pykrita: expose the real i18n() function

Summary

Using QCoreApplication.translate() as i18n() function in pykrita does
not work, since the translations are not in Qt .qm files, but in
Gettext .po files.

Hence, create an helper krita_i18n() function in libkis, bind it with
SIP, and set it as builtin i18n() function for pykrita (and thus for
all the Python plugins). This fixes most of the lack of translations
in Python plugins.

Test Plan

Builds fine, and Python plugins are translated properly
(mostly, since there are few more issues, but unrelated to this).

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

pino created this revision.Jun 23 2018, 8:53 AM

Restricted Application added a project: Krita. · View Herald TranscriptJun 23 2018, 8:53 AM

pino requested review of this revision.Jun 23 2018, 8:53 AM

Harbormaster completed remote builds in B243: Diff 36552.Jun 23 2018, 8:53 AM

Awesome, thank you!

This revision is now accepted and ready to land.Jun 24 2018, 11:02 AM

Closed by commit R37:b7b398897132: pykrita: expose the real i18n() function (authored by pino). · Explain WhyJun 24 2018, 11:09 AM

This revision was automatically updated to reflect the committed changes.

woltherav awarded a token.Jun 24 2018, 12:34 PM

Revision Contents
Changeset List

			Path	Packages
M			libs/libkis/Krita.h (2 lines)
M			libs/libkis/Krita.cpp (6 lines)
M			plugins/extensions/pykrita/plugin/krita/__init__.py (2 lines)
M			plugins/extensions/pykrita/sip/krita/Krita.sip (1 line)