Details
Diff Detail
- Repository
- R134 Discover Software Store
- Branch
- fix-toolbar-layout-regression (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 227 Build 227: arc lint + arc unit
| discover/qml/DiscoverWindow.qml | ||
|---|---|---|
| 30 | why the logic of all of this? | |
oh, yes, i know why the extra space problem, i'll fix
| discover/qml/DiscoverWindow.qml | ||
|---|---|---|
| 30 | no applicationheader should be there at any point, in any formfactor, unless you want something to go on top of the toolbar | |
Aleix implemented a better version of this with https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233
I'm still not sure about it.
is it supposed to switch to breadcrumb when the window is narrow? (and buttons as fab on the bottom) in kirigami desktop apps are supposed to always have the top toolbar, even when they are narrow, that's why it gets navigation buttons, even when they are in tablet mode: bottom action buttons are purely for reachability in single hand mode on phones.
Note that this has nothing to do with plasma mobile, there it would always be in breadcrumb+fab mode (you can test its behavior on desktop with export QT_QUICK_CONTROLS_MOBILE=1)