Differential D13629

Fix crashing devicetest
ClosedPublic
Actions

Authored by nicolasfella on Jun 20 2018, 12:25 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:48108cd31619: Fix crashing devicetest
Summary

When running the test m_impl will be nullptr leading to a crash. This is because when running as a test no platform is loaded.
The fancy way to solve this would be to have a TestImpl, but I think this is enough.

Test Plan

Test passes now

Diff Detail

Repository
R224 KDE Connect
Branch
fixtest
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 147
Build 147: arc lint + arc unit
nicolasfella created this revision.Jun 20 2018, 12:25 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJun 20 2018, 12:25 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Jun 20 2018, 12:25 PM
nicolasfella edited the test plan for this revision. (Show Details)Jun 20 2018, 12:39 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella updated this revision to Diff 36383.Jun 20 2018, 1:21 PM
  • Make test pass
nicolasfella updated this revision to Diff 36384.Jun 20 2018, 1:25 PM
  • Make test pass

The device might be trusted from a previous test run

nicolasfella updated this revision to Diff 36385.Jun 20 2018, 1:26 PM
  • Whitespace
nicolasfella edited the test plan for this revision. (Show Details)Jun 20 2018, 1:26 PM
apol accepted this revision.Jul 12 2018, 2:09 PM
This revision is now accepted and ready to land.Jul 12 2018, 2:09 PM
apol added inline comments.Jul 12 2018, 2:10 PM
plugins/mousepad/mousepadplugin.cpp
85–87 ↗(On Diff #36380)

in which cases m_impl is null?

nicolasfella added inline comments.Jul 12 2018, 2:14 PM
plugins/mousepad/mousepadplugin.cpp
85–87 ↗(On Diff #36380)

For tests neither HAVE_X11, HAVE_WAYLAND or HAVE_WINDOWS is true

Closed by commit R224:48108cd31619: Fix crashing devicetest (authored by nicolasfella). · Explain WhyJul 12 2018, 2:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36383

View Options

plugins/mousepad/mousepadplugin.cpp

Loading...
View Options

tests/devicetest.cpp

Loading...