KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName
ClosedPublic

Authored by kossebau on Jun 19 2018, 9:01 PM.

Details

Summary

This key was introduced in 2008 in some places, but seems it got never
taken into account by the actual kded module loading code when deciding
about the name for the module's D-Bus object path
(at least by what I found in the kdelibs/kded/kdbusaddons repo history).

As any existing kded modules are fine with getting the D-Bus module
name derived from the plugin id (either as set via plugin metadata or
by the binary name), this unused key can be removed again.

Diff Detail

Repository
R297 KDED
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jun 19 2018, 9:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 19 2018, 9:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jun 19 2018, 9:01 PM
dfaure accepted this revision.Jun 19 2018, 9:17 PM

Indeed, not used, and not useful.

This revision is now accepted and ready to land.Jun 19 2018, 9:17 PM
This revision was automatically updated to reflect the committed changes.