fix potential crash
ClosedPublic
Actions

Authored by sandsmark on Jun 19 2018, 7:53 PM.

Details

Reviewers

hindenburg
tcanabrava

Group Reviewers

Konsole

Summary

revert the change to allocate the dialog on the stack, the original code was that way for a reason:

there's some other minor issues with the patch set, but I don't think they're going to cause crashes.

Repository

R319 Konsole

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

sandsmark requested review of this revision.Jun 19 2018, 7:53 PM

I recall this now - I wonder if this is still true 9+ years later. If we revert, let's at least add a comment about this issue in the code

For now, let's just revert and we can look at this later if needed.

This revision is now accepted and ready to land.Jun 22 2018, 10:45 AM

			Path	Packages
M			settings/ProfileSettings.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36353			Jun 19 2018, 7:49 PM	★	★