[lnf] Add Qt VirtualKeyboard optionally to lock screen
AbandonedPublic

Authored by graesslin on Apr 8 2016, 1:36 PM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Maniphest Tasks
T2177: Virtual Keyboard for lock screen
Summary

The virtual keyboard is integreted through a Loader and guarded by
a property which is set from the kscreenlocker greeter to ensure that
it still works even if the plugin is not available.

The virtual keyboard is not yet positioned properly in the lock screen,
e.g. on my system it overlaps the password field. So there is still some
work needed by more experienced QML hackers.

For more information see:

Diff Detail

Repository
R120 Plasma Workspace
Branch
lnf-virtual-keyboard
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 3221.Apr 8 2016, 1:36 PM
graesslin retitled this revision from to [lnf] Add Qt VirtualKeyboard optionally to lock screen.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2016, 1:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas added a subscriber: sebas.Apr 14 2016, 10:20 AM
sebas added inline comments.
CMakeLists.txt
100

Encapsulate this in a find module? Makes it easier to reuse in the future, and less "weird" constructs, like the index checking in the top-level cmake files.

lookandfeel/contents/lockscreen/LockScreen.qml
33

Where is this set to true?

graesslin added inline comments.Apr 14 2016, 12:03 PM
CMakeLists.txt
100

yeah might be a good idea, any idea where we could put it to share it between kscreenlocker and plasma-workspace?

lookandfeel/contents/lockscreen/LockScreen.qml
33

Where is this set to true?

see https://phabricator.kde.org/D1359 greeter/greeterapp.cpp line 262

sebas added inline comments.Apr 14 2016, 12:39 PM
CMakeLists.txt
100

Other than E-C-M, not really.

You can just put it here and perhaps copy it into plasma-workspace for now, it's simple enough so that it shouldn't cause a lot of churn. Once more people are interested, it can perhaps still go to E-C-M.

Note: I'm not sure about the exact rules for E-C-M inclusion.

lookandfeel/contents/lockscreen/LockScreen.qml
33

Right, just found it there. Thanks...

sebas accepted this revision.Apr 15 2016, 12:41 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Apr 15 2016, 12:41 PM

Thanks for accepting, but I haven't create the Find module yet ;-)

graesslin added inline comments.Apr 15 2016, 2:41 PM
CMakeLists.txt
100

sorry, but my CMake foo is not sufficient to try to get this into a Find-module.

graesslin abandoned this revision.Sep 6 2016, 10:22 AM

Abandon as the theme changed and I'm rather for adding it to be shown from KWin.