Differential D1356

[kstyle] Only create Wayland shadows for top-level widgets
ClosedPublic
Actions

Authored by graesslin on Apr 8 2016, 9:08 AM.

Details

Reviewers
hpereiradacosta
Group Reviewers
Plasma
Commits
R113:c5edbc8365a6: [kstyle] Only create Wayland shadows for top-level widgets

Diff Detail

Repository
R113 Oxygen Theme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3213.Apr 8 2016, 9:08 AM
graesslin retitled this revision from to [kstyle] Only create Wayland shadows for top-level widgets.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, hpereiradacosta.
graesslin added a project: Plasma.Apr 8 2016, 9:09 AM
graesslin added a subscriber: plasma-devel.
hpereiradacosta accepted this revision.Apr 8 2016, 9:22 AM
hpereiradacosta edited edge metadata.

Ship it !
I wonder if this shouldn't actually go "upstream", for both the X11 and the Wayland implementation. Is there a reason why we should have, on X11 shadows installed on something that does not have a window handle ?

This revision is now accepted and ready to land.Apr 8 2016, 9:22 AM
Closed by commit R113:c5edbc8365a6: [kstyle] Only create Wayland shadows for top-level widgets (authored by graesslin). · Explain WhyApr 8 2016, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstyle/oxygenshadowhelper.cpp (2 lines)

Diff 3215

View Options

kstyle/oxygenshadowhelper.cpp

Loading...