Differential D1348

Testing whether m_lastCreatedSettings is not null before calling its method
ClosedPublic
Actions

Authored by ivan on Apr 7 2016, 6:10 PM.

Details

Reviewers
graesslin
Commits
R108:1fef4760bf1d: Testing whether m_lastCreatedSettings is not null before calling its method
Summary

It looks like something was forgotten here - there is
a completely empty body for an if statement that checks
whether the pointer is null.
So this might not be the desired way to fix this.
Should m_lastCreatedSettings be instantiated instead?

Diff Detail

Repository
R108 KWin
Branch
ivan/null-check-3
Lint
No Linters Available
Unit
No Unit Test Coverage
ivan updated this revision to Diff 3199.Apr 7 2016, 6:10 PM
ivan retitled this revision from to Testing whether m_lastCreatedSettings is not null before calling its method.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added a reviewer: graesslin.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2016, 6:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Apr 8 2016, 6:03 AM
graesslin edited edge metadata.

yeah, that's the only way it makes sense. But I don't remember what was intended ;-)

This revision is now accepted and ready to land.Apr 8 2016, 6:03 AM
Closed by commit R108:1fef4760bf1d: Testing whether m_lastCreatedSettings is not null before calling its method (authored by ivan). · Explain WhyApr 8 2016, 7:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3199

View Options

kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp

Loading...