Keep job removal icon disabled when Scheduler stops
ClosedPublic

Authored by TallFurryMan on Jun 10 2018, 8:24 PM.

Details

Summary

This change prevents the job removal icon from being enabled when the Scheduler stops, as this may cause the user to delete a job without any preliminary hint on which job will be removed.

Test Plan

Add a few jobs to the scheduler, check the removal icon: it is enabled only if a job is selected in edit mode.
Start the scheduler, then stop the scheduler, check the removal icon.
Without the change, the removal icon is unexpectedly enabled, and no hint of any job to be deleted is visible.
Clicking the removal icon effectively removes a job.
With the change, the removal icon remains properly disabled until a job is selected, preventing the user from deleting any job.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Jun 10 2018, 8:24 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 10 2018, 8:24 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Jun 10 2018, 8:24 PM

Doesn't it remove the last job?

It probably does, but there's no visual hint it will do that. If the user doesn't know that this is a feature, or if the last job is out of view, it's even difficult to tell which job disappeared.

mutlaqja accepted this revision.Jun 11 2018, 8:22 AM
This revision is now accepted and ready to land.Jun 11 2018, 8:22 AM
This revision was automatically updated to reflect the committed changes.