resize metadata view dynamically
ClosedPublic

Authored by astippich on Jun 10 2018, 12:01 PM.

Details

Summary

resize the metadata view depending on its content, but provide a maximum width to avoid very wide windows

BUG: 393303

Test Plan

resizes correctly with different labels and metadata content, no overlap

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Jun 10 2018, 12:01 PM
astippich created this revision.
mgallien requested changes to this revision.Jun 20 2018, 9:03 PM

Shows the state of the metadata detail view.

It is still not resizable even if kwin adds a resize handle.
There is also problems with the close button being partially covered and the track path being partially hidden.

Please try to fix it

This revision now requires changes to proceed.Jun 20 2018, 9:03 PM
astippich updated this revision to Diff 36483.Jun 21 2018, 7:29 PM
  • more tweaks for the metadata view
  • make window width resizable

The view looks slightly different here with more margins, so kind of hard to fix.
The size was fixed by design. I made the width now adjustable and added some more smaller tweaks, could you please test?

ping. I think this should go into 0.2

mgallien requested changes to this revision.Jul 3 2018, 8:27 PM

Sorry for the big delay on my side. I am trying to go over my backlog of reviews.

With your patch I am getting this

Could you add some margins at bottom and right ?

Something like that

This revision now requires changes to proceed.Jul 3 2018, 8:27 PM
astippich updated this revision to Diff 37666.Jul 12 2018, 7:19 PM
  • add margin
mgallien accepted this revision.Jul 14 2018, 3:38 PM

Works better than before. The bottom margin is different when a cover is present and a cover is missing. At least the close button is no longer hidden.

This revision is now accepted and ready to land.Jul 14 2018, 3:38 PM
This revision was automatically updated to reflect the committed changes.