Differential D13428

De duplicate setContainerFeatures
ClosedPublic
Actions

Authored by tcanabrava on Jun 8 2018, 1:47 PM.

Tags

Subscribers

ahmadsamir, konsole-devel

Details

Reviewers

Group Reviewers

Commits

R319:8c7d05f3a7cf: De duplicate setContainerFeatures

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tcanabrava created this revision.Jun 8 2018, 1:47 PM

Restricted Application added a project: Konsole. · View Herald TranscriptJun 8 2018, 1:47 PM

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

tcanabrava requested review of this revision.Jun 8 2018, 1:47 PM

tcanabrava retitled this revision from De-Duplicate code to De duplicate setContainerFeatures.Jun 8 2018, 1:49 PM

tcanabrava edited the summary of this revision. (Show Details)

tcanabrava added reviewers: hindenburg, Konsole.

ahmadsamir added a subscriber: ahmadsamir.Jun 8 2018, 6:52 PM

ahmadsamir added inline comments.

src/ViewManager.cpp
1225–1226	Since you're touching this bit of code anyway, this might be a good time to replace foreach (which is being deprecated) with a range-for loop. http://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH https://www.kdab.com/goodbye-q_foreach/

Use range-for

tcanabrava marked an inline comment as done.Jun 9 2018, 7:50 AM

hindenburg accepted this revision.Jun 9 2018, 10:47 PM

This revision is now accepted and ready to land.Jun 9 2018, 10:47 PM

Closed by commit R319:8c7d05f3a7cf: De duplicate setContainerFeatures (authored by tcanabrava, committed by hindenburg). · Explain WhyJun 9 2018, 10:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/ViewManager.h (3 lines)
M			src/ViewManager.cpp (34 lines)

Diff 35918

src/ViewManager.h

Loading...

src/ViewManager.cpp

Loading...