Differential D13401

Improve dragging notes
ClosedPublic
Actions

Authored by hoffmannrobert on Jun 7 2018, 11:41 AM.

Details

Reviewers
mlaurent
Commits
R208:026124bd51ee: Merge remote-tracking branch 'origin/Applications/18.04'
R208:3f2d00d663e1: Apply patch from Robert Hoffmann
Summary

To prevent the note from jumping with its left upper
corner to the mouse position when starting a drag,
consider the relative position of the mouse cursor
within the note when calculating the new position.

Diff Detail

Repository
R208 KNotes
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
hoffmannrobert created this revision.Jun 7 2018, 11:41 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 7 2018, 11:41 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
hoffmannrobert requested review of this revision.Jun 7 2018, 11:41 AM
cfeck added a subscriber: cfeck.Jun 7 2018, 12:54 PM
cfeck added inline comments.
src/notes/knote.cpp
1177 ↗(On Diff #35747)

Make that a member variable.

hoffmannrobert updated this revision to Diff 35775.Jun 7 2018, 3:20 PM

Use member variable

hoffmannrobert marked an inline comment as done.Jun 7 2018, 3:22 PM
mlaurent accepted this revision.Jun 14 2018, 5:05 AM
mlaurent added a subscriber: mlaurent.

Work fine :)
thanks
I will commit it as you don't have commit access.

This revision is now accepted and ready to land.Jun 14 2018, 5:05 AM
Closed by commit R208:3f2d00d663e1: Apply patch from Robert Hoffmann (authored by mlaurent). · Explain WhyJun 14 2018, 5:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/notes/knote.h (1 line)
Msrc/notes/knote.cpp (18 lines)

Diff 35775

View Options

src/notes/knote.h

Loading...
View Options

src/notes/knote.cpp

Loading...