Play_piano activity is complete as per planned implementation: https://phabricator.kde.org/T8951
Details
Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Activities - Maniphest Tasks
- T8951: play_piano, lay down UI of the activity and implement working logic and levels.
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| src/activities/piano_composition/MultipleStaff.qml | ||
|---|---|---|
| 43 ↗ | (On Diff #35638) | Notes are to be centered at the staff for activites like play_piano and play_rhythm. |
| 303 ↗ | (On Diff #35638) | To mark and indicate if the answered note is correct or not. Will document the usage of all functions before committing. This function and the function below, revertAnswer are then only 2 new functions added. I guess we will not need to add anymore functions for the remaining piano activities now. |
| src/activities/piano_composition/MultipleStaff.qml | ||
|---|---|---|
| 162 | if you don't need anymore the logs, you can remove them | |
| 138 ↗ | (On Diff #35638) | can you name the clefType directly "Treble" and "Bass"? |
| src/activities/play_piano/PlayPiano.qml | ||
| 124 | is there a better name than "easy"/"hard"? | |
| 281 ↗ | (On Diff #35638) | All the options should be invisible by default (in OptionsRow.qml) and there and in piano_composition, you should set them to the values you want |