Improve the clarity and presentation of the update details text field
ClosedPublic

Authored by ngraham on Jun 5 2018, 5:53 PM.

Details

Summary

This patche makes it a bit more obvious what's actually going to happen if you click an update to see its details; you get a clear indication of the current version and the new version in the order that your brain expects them to be in.

Test Plan

Tested in KDE Neon. Before:

After:

Needs testing on other platforms that may format things differently.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 5 2018, 5:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 5 2018, 5:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 5 2018, 5:53 PM
ngraham edited the test plan for this revision. (Show Details)Jun 5 2018, 5:54 PM
apol accepted this revision.Jun 5 2018, 5:56 PM
This revision is now accepted and ready to land.Jun 5 2018, 5:56 PM

Does this work satisfactorily for you on Arch?

broulik added a subscriber: broulik.Jun 6 2018, 2:04 PM
broulik added inline comments.
libdiscover/backends/PackageKitBackend/PackageKitResource.cpp
222

You don't need the i18nc at all anymore as you just forward the string verbatim

ngraham updated this revision to Diff 35803.Jun 7 2018, 9:23 PM

Use the simpler i18n function call

ngraham updated this revision to Diff 35804.Jun 7 2018, 9:25 PM
ngraham marked an inline comment as done.

Use an even simpler total lack of i18n, since we don't actually change the string at ally

Oops, thanks!

Before landing this, I'd still prefer a quick test from anyone not using an Ubuntu-based distro to make sure that the strings still make sense. Thanks!

This revision was automatically updated to reflect the committed changes.