Differential D13349

[KBalooRolesProvider] Support properties of type QStringList
ClosedPublic
Actions

Authored by broulik on Jun 5 2018, 8:16 AM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:2f6635f4e8c2: [KBalooRolesProvider] Support properties of type QStringList
Summary

QVariant::toString() unwraps a QStringList with a single string to a QString, however a list with multiple entries returns a null string.
Explicitly check for KFileMetaData property type and convert accordingly.

BUG: 395033
FIXED-IN: 18.04.3

Test Plan
  • Had an mp3 file with multiple artists, shows correctly in table view
  • Single artist also still shows fine

(The surrounding tags code also uses hardcoded non-i18n ", " so this is consistent with the rest)

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 5 2018, 8:16 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 5 2018, 8:16 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Jun 5 2018, 8:16 AM
elvisangelaccio accepted this revision as: elvisangelaccio.Jun 5 2018, 8:29 PM

Though we should probably fix the non-localized ", " usage, eventually :D

This revision is now accepted and ready to land.Jun 5 2018, 8:29 PM
Closed by commit R318:2f6635f4e8c2: [KBalooRolesProvider] Support properties of type QStringList (authored by broulik). · Explain WhyJun 6 2018, 7:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35665

View Options

src/kitemviews/private/kbaloorolesprovider.cpp

Loading...