Merge branch 'master' into card
Added recomendation for aspect ratio
Add3d remoendation for padding to card
added 2 images for cards
Added recomendation about focus on one bit of content to cards
Merge branch 'master' into card
mart |
VDG |
Merge branch 'master' into card
Added recomendation for aspect ratio
Add3d remoendation for padding to card
added 2 images for cards
Added recomendation about focus on one bit of content to cards
Merge branch 'master' into card
No Linters Available |
No Unit Test Coverage |
Buildable 186 | |
Build 186: arc lint + arc unit |
source/components/card.rst | ||
---|---|---|
26 | what does this line mean? | |
53 | number of columns? | |
60 | how the component works right now is to support one basic layout: some custom content can be put inside/in place of the text, and stuff can be stuffed in the top image as well for other different kind of content there is the "empty" card which is just the white rectangle with shadow, which then becomes completely the app's responsibility on what layout to use in it |
source/components/card.rst | ||
---|---|---|
26 | Changed the suggestion to be more clear. |
source/components/card.rst | ||
---|---|---|
60 | I would add a implementation section in another patch, and give hints for devs about the existing layouts there. |
source/components/editing/card.rst | ||
---|---|---|
60 ↗ | (On Diff #38092) | I would like to recomend instead to use the standard layout, the one that has a component (image on top, then text, then action buttons) and exampes where something completely custom would be used instead |
Great HIG!
Only one suggested rephrasing and one small typo fix (see inline comments).
source/components/editing/card.rst | ||
---|---|---|
66 ↗ | (On Diff #38092) | "Use a lot" sounds a bit too strong (I don't think we want people to overload their cards with visual fluff just because the HIG said so) Use images, icons or video elements to create visually immersive cards. |
69 ↗ | (On Diff #38092) | ration -> ratio |