Differential D13287

FrameSVG: Delete redundant checks
ClosedPublic
Actions

Authored by zzag on Jun 2 2018, 3:54 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Frameworks
Commits
R242:b169aa50f917: FrameSVG: Delete redundant checks
Summary

There is no need to check whether cachedBackground is null, and if
it's null, return a null pixmap.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 2 2018, 3:54 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 2 2018, 3:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Jun 2 2018, 3:54 PM
apol accepted this revision.Jun 4 2018, 1:07 AM
This revision is now accepted and ready to land.Jun 4 2018, 1:07 AM
zzag added a comment.Jun 4 2018, 7:56 AM

@apol Do I need to wait for other reviewers (from plasma)? Or I can land it right away?

apol added a comment.Jun 4 2018, 11:21 AM

:( am I not plasma enough?

zzag added a comment.Jun 4 2018, 4:40 PM
In D13287#273556, @apol wrote:

:( am I not plasma enough?

Sorry, I still don't know who is who. :D

Closed by commit R242:b169aa50f917: FrameSVG: Delete redundant checks (authored by zzag). · Explain WhyJun 4 2018, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (7 lines)

Diff 35541

View Options

src/plasma/framesvg.cpp

Loading...