Differential D13281

More 2.0 cleanups
ClosedPublic
Actions

Authored by rizzitello on Jun 2 2018, 10:50 AM.

Details

Reviewers
tcanabrava
laysrodrigues
patrickelectric
Commits
R232:e30c420325c5: String adjust, translate user facing
R232:8c2994a42c80: Remove foreach replace with newer style for loops
R232:328982799d3d: Remove impossible to trigger code
R232:dce3a4d28d89: cleanup findFirmwarePlugins
R232:abed56472cf5: Add signal atcoreMessage(const QString &msg). It will emit if - Waiting on…
R232:7c2bf8e124d5: More 2.0 cleanups
Summary
  • FOREACH => for
  • Ensure tr calls
  • cleanup findFirmwarePlugins
  • Remove impossible to trigger code
  • Add signal atcoreMessage(const QString &msg). It will emit if
    • Waiting on Firmware Detect.
    • No Plugin found for Detected Firmware
    • Failed to open device in R/W mode
  • update atcore-gui

Diff Detail

Repository
R232 AtCore
Branch
morestuff
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Jun 2 2018, 10:50 AM
rizzitello created this revision.
rizzitello updated this revision to Diff 35398.Jun 2 2018, 12:10 PM
  • Remove Debug tr calls.
rizzitello updated this revision to Diff 35400.Jun 2 2018, 12:20 PM
  • remove stray %1
patrickelectric requested changes to this revision.Jun 2 2018, 12:26 PM
patrickelectric added inline comments.
src/core/atcore.cpp
132

qCWarning

150–151

If you are in this line, no firmware will be loaded.

151

How we are supposed to debug 'debug messages' if we do not understand the language ?

This revision now requires changes to proceed.Jun 2 2018, 12:26 PM
rizzitello marked 2 inline comments as done.Jun 2 2018, 12:29 PM
rizzitello added inline comments.
src/core/atcore.cpp
150–151

This is connected to the serialLayers received message signal and is called for ever message until a firmware plugin is loaded.

151

was really just trying to avoid the duplication of the string but i see your point.

rizzitello updated this revision to Diff 35402.Jun 2 2018, 12:52 PM
rizzitello marked 2 inline comments as done.
  • Patrick's suggestions
rizzitello marked 3 inline comments as done.Jun 2 2018, 12:52 PM
patrickelectric requested changes to this revision.Jun 2 2018, 12:54 PM
patrickelectric added inline comments.
src/core/atcore.cpp
502

no tr in debug messages please.

This revision now requires changes to proceed.Jun 2 2018, 12:54 PM
rizzitello updated this revision to Diff 35405.Jun 2 2018, 12:58 PM
rizzitello marked an inline comment as done.
  • remove last tr
patrickelectric accepted this revision.Jun 2 2018, 1:03 PM

I think that everything is ok, but I would prefer others review to see if this PR is suitable. I have my doubts

This revision is now accepted and ready to land.Jun 2 2018, 1:03 PM
rizzitello closed this revision.Jun 2 2018, 1:04 PM

Revision Contents
Changeset List

Diff 35405

View Options

src/core/atcore.h

Loading...
View Options

src/core/atcore.cpp

Loading...
View Options

src/core/printthread.cpp

Loading...
View Options

src/core/seriallayer.cpp

Loading...
View Options

src/widgets/about.cpp

Loading...
View Options

src/widgets/axiscontrol.cpp

Loading...
View Options

testclient/mainwindow.cpp

Loading...