The goal of this patch is to open supported files in alike ways i.e. through KMyMoneyPlugin::StoragePlugin. This is the first step to make Qt5::Xml dependency optional by encapsulating saving as XML file in a plugin.
The patch is transient as "opening", "saving" and "saving as" could be made consistent in kmymoney.cpp. GNC reader could also be made consistent with XML and SQL storage. KMyMoneyPlugin::StoragePlugin could also be extended by identification of its own file formats.
With this patch I want to know if all works well.
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:dc335bcaf0d9: Pluginize XML Storage
Used save, save as and open XML and GNC file.
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
In general looks OK to me. Did some casual testing (saving/loading).
| kmymoney/kmymoney.cpp | ||
|---|---|---|
| 2405 | Why don't you use QLatin1String here? | |
Comment Actions
- Open kmm (xml) file
- Disable xml storage plugin and close kmm
- Start kmm again
[kmm tries to load last used (xml) file (and xml storage plugin disabled)]
- "Couldn't find suitable plugin to read your storage." Press "OK"
- Crash
Comment Actions
I know about this. It was present before with SQL storage. I'm working on making opening, saving and closing files reliable and more transparent. Please be patient.