Details
Details
- Reviewers
ivan - Group Reviewers
Plasma - Commits
- R845:42723bb3cb70: Make dependency on KF5NetworkManagerQt optional
Diff Detail
Diff Detail
- Repository
- R845 Plasma Vault
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this.
- Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not.
- What about the configuration UI?
Comment Actions
Very nice, thanks. If you want I can accept this (after the Q_UNUSED change) and I'll do the UI patch separately.
kded/service.cpp | ||
---|---|---|
53 | You should use Q_UNUSED instead. |