Make dependency on KF5NetworkManagerQt optional
ClosedPublic

Authored by asturmlechner on May 31 2018, 9:23 PM.

Diff Detail

Repository
R845 Plasma Vault
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
asturmlechner created this revision.May 31 2018, 9:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 31 2018, 9:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
asturmlechner requested review of this revision.May 31 2018, 9:23 PM

(this is me forwarding a Gentoo user contribution)

ivan requested changes to this revision.Jun 1 2018, 6:28 PM
  • Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this.
  • Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not.
  • What about the configuration UI?
This revision now requires changes to proceed.Jun 1 2018, 6:28 PM

Update addressing 2/3 points raised

ivan added a comment.Jun 9 2018, 8:02 PM

Very nice, thanks. If you want I can accept this (after the Q_UNUSED change) and I'll do the UI patch separately.

kded/service.cpp
53

You should use Q_UNUSED instead.

Use Q_UNUSED

ivan accepted this revision.Jun 12 2018, 5:10 AM

Thanks!

This revision is now accepted and ready to land.Jun 12 2018, 5:10 AM
This revision was automatically updated to reflect the committed changes.