Watch for installation of kipi-plugins only when needed
ClosedPublic

Authored by rkflx on May 31 2018, 7:10 PM.

Details

Summary

When kipi-plugins was not installed and the user clicked on the
Plugins menu at least once, a filesystem watcher was added
unconditionally. This resulted in a huge amount of signals and
unnecessary updates in Gwenview as soon as any software installation
took place. In particular this was bad for packages with lots of files
like the kernel headers.

It's enough to add the watcher only in case the user actively clicked on
Install Plugins.

FIXED-IN: 18.04.2

Test Plan

Remove kipi-plugins, make sure Discover is installed, start
Gwenview and click on PluginsInstall Plugins. Check that the
list of plugins still updates itself as soon as the installation
completes successfully.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.May 31 2018, 7:10 PM
rkflx created this revision.
ngraham accepted this revision as: ngraham.Jun 1 2018, 4:37 AM

Ooh, nice catch.

This revision is now accepted and ready to land.Jun 1 2018, 4:37 AM
This revision was automatically updated to reflect the committed changes.