Differential D13236

piano_composition, add display of lyrics
ClosedPublic
Actions

Authored by amankumargupta on May 31 2018, 1:19 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Activities
Maniphest Tasks
T8920: piano_composition, add display of lyrics

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
amankumargupta created this revision.May 31 2018, 1:19 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 31 2018, 1:19 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
jjazeix added a subscriber: jjazeix.May 31 2018, 1:55 PM
jjazeix added inline comments.
src/activities/piano_composition/MultipleStaff.qml
204 ↗(On Diff #35252)

I don't like the idea of clearing the lyrics on an eraseAllNotes function, is there another way to do it?

src/activities/piano_composition/Piano_composition.qml
282

you can probably create a new file for this

amankumargupta updated this revision to Diff 35264.May 31 2018, 3:22 PM
  1. Moved LyricsArea as a new file.
  1. Changed the way lyrics and other melody data were set in LyricsArea.
amankumargupta marked an inline comment as done.May 31 2018, 3:45 PM
jjazeix accepted this revision.Jun 3 2018, 10:16 AM
This revision is now accepted and ready to land.Jun 3 2018, 10:16 AM

Revision Contents
Changeset List

Diff 35264

View Options

src/activities/piano_composition/LyricsArea.qml

Loading...
View Options

src/activities/piano_composition/MelodyList.qml

Loading...
View Options

src/activities/piano_composition/Piano_composition.qml

Loading...
View Options

src/activities/piano_composition/SwitchableOptions.qml

Loading...
View Options

src/activities/piano_composition/piano_composition.js

Loading...
View Options

src/activities/piano_composition/resource/lyrics-icon.svg

Loading...
View Options

src/activities/piano_composition/resource/piano-icon.svg

Loading...