Differential D13233

Support for the Custom color set
AbandonedPublic
Actions

Authored by mart on May 31 2018, 9:57 AM.

Details

Reviewers
broulik
Group Reviewers
Kirigami
Summary

In some scenarios, some applications need certain areas with completely custom
palettes, for instance if a piece of ui is on top of an image it may make
sense that hierarchy uses whatever the dominant colors of such image are.
in the scenario of a Custom color set, the qml code would look like this:
needs D13232
Item {

Kirigami.Theme.inherit: false
Kirigami.Theme.colorSet: Kirigami.Theme.Custom
Kirigami.Theme.textColor: "#af2352"
Kirigami.Theme.backgroundColor: "#124523"

...

}

Test Plan

piece with a custom set in the gallery

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
mart/customColors
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.May 31 2018, 9:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 31 2018, 9:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.May 31 2018, 9:57 AM
mart mentioned this in D13232: introduce Custom color set.EditedMay 31 2018, 9:57 AM
mart added a reviewer: broulik.

note that some pieces of breeze controls can't have a custom color as breeze uses kcolorscheme directly for them, so they can only be read from kdeglobals (mouseover effect for buttons doesn't work as well in the current colors kcm preview for this reason)

davidedmundson added a subscriber: davidedmundson.May 31 2018, 10:07 AM
davidedmundson added inline comments.
kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
177

I don't understand this part of the patch in relation to custom color set support.

mart abandoned this revision.Jun 5 2018, 12:05 PM

Revision Contents
Changeset List

Diff 35244

View Options

kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp

Loading...