Differential D13218

FrameSvg: Draw corners only if both borders in both directions are enabled
ClosedPublic
Actions

Authored by zzag on May 30 2018, 4:34 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Frameworks
Commits
R242:a46cd14553c2: FrameSvg: Draw corners only if both borders in both directions are enabled
Summary

FrameSVG documentation states

... topleft and topright will be ignored if top does not exist,
and similarly for bottomleft and bottomright ...

Someone would assume that the same behaviour applies to the case
when left(or right) does not exist.

This change makes FrameSVG to comply with such expected behaviour.

Before

The bottom border doesn't exist so the bottom-right corner should not
be drawn.

After

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.May 30 2018, 4:34 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 30 2018, 4:34 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.May 30 2018, 4:34 PM
zzag edited the summary of this revision. (Show Details)May 30 2018, 4:35 PM
zzag edited the summary of this revision. (Show Details)
zzag edited the summary of this revision. (Show Details)May 31 2018, 10:23 AM
zzag retitled this revision from Draw FrameSVG corners only if both borders in both directions are enabled to FrameSvg: Draw corners only if both borders in both directions are enabled.Jun 6 2018, 3:06 PM

Ping.

mart added a subscriber: mart.Jun 6 2018, 4:19 PM
This comment was removed by mart.
mart accepted this revision.Jun 6 2018, 4:20 PM
mart added a project: Plasma.
This revision is now accepted and ready to land.Jun 6 2018, 4:21 PM
zzag added a comment.EditedJun 6 2018, 4:24 PM
In D13218#274785, @mart wrote:

how does this relates with D13215?

If maskFrame isn't recached after enabledBorders has been changed, I would expect the "After" picture rather than the "Before" picture because the bottom part isn't enabled. (sorry for broken English)

Closed by commit R242:a46cd14553c2: FrameSvg: Draw corners only if both borders in both directions are enabled (authored by zzag). · Explain WhyJun 6 2018, 5:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (8 lines)

Diff 35697

View Options

src/plasma/framesvg.cpp

Loading...