Differential D13199

Move updateDevice to private class
ClosedPublic
Actions

Authored by nicolasfella on May 29 2018, 4:02 PM.

Tags

Subscribers

Details

Reviewers

Commits

R994:65bad933c12c: Move updateDevice to private class

Test Plan

KDE Connect volume control still works

Diff Detail

Repository

R994 Pulseaudio Qt Bindings

Branch

movetoprivate

Lint

No Linters Available

Unit

No Unit Test Coverage

nicolasfella created this revision.May 29 2018, 4:02 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2018, 4:02 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

nicolasfella requested review of this revision.May 29 2018, 4:02 PM

drosca accepted this revision.May 30 2018, 8:52 AM

This revision is now accepted and ready to land.May 30 2018, 8:52 AM

Closed by commit R994:65bad933c12c: Move updateDevice to private class (authored by nicolasfella). · Explain WhyMay 30 2018, 10:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/device.h (6 lines)
M			src/device.cpp (12 lines)
M			src/device_p.h (88 lines)
M			src/port.h (2 lines)
M			src/sink.cpp (2 lines)
M			src/source.cpp (2 lines)
M			src/volumeobject.h (1 line)

Diff 35126

src/device.h

Loading...

src/device.cpp

Loading...

src/device_p.h

Loading...

src/port.h

Loading...

src/sink.cpp

Loading...

src/source.cpp

Loading...

src/volumeobject.h

Loading...