Differential D13191

[server] Small code cleanup in SurfaceInterface
ClosedPublic
Actions

Authored by romangg on May 29 2018, 10:37 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R127:31b1c144fde7: [server] Small code cleanup in SurfaceInterface
Summary

Use lambda function to reduce code duplication and put
function definitions in the same order as in the header file.

Test Plan

All autotests succeed.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.May 29 2018, 10:37 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 29 2018, 10:37 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
romangg requested review of this revision.May 29 2018, 10:37 AM
davidedmundson added a subscriber: davidedmundson.May 29 2018, 11:25 AM

function definitions in correct order.

What's more correct about this order?

romangg added a comment.May 29 2018, 11:29 AM
In D13191#270177, @davidedmundson wrote:

function definitions in correct order.

What's more correct about this order?

In surface_interface_p.h the functions are declared in this order:

void installPointerConstraint(LockedPointerInterface *lock);
void installPointerConstraint(ConfinedPointerInterface *confinement);
void installIdleInhibitor(IdleInhibitorInterface *inhibitor);

In the cpp file they were defined in a different order. It's just a small code style correction.

davidedmundson accepted this revision.Jun 4 2018, 10:31 AM
This revision is now accepted and ready to land.Jun 4 2018, 10:31 AM
romangg edited the summary of this revision. (Show Details)Jun 4 2018, 10:34 AM
Closed by commit R127:31b1c144fde7: [server] Small code cleanup in SurfaceInterface (authored by romangg). · Explain WhyJun 10 2018, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/server/surface_interface.cpp (96 lines)

Diff 35957

View Options

src/server/surface_interface.cpp

Loading...