Switch to the Attica framework
ClosedPublic

Authored by pino on May 28 2018, 8:56 PM.

Details

Summary

Switch from the old version of Attica, libattica-ocsclient, to the
frameworks version of Attica, adapting the code in the following ways:

  • manually load the providers using ProviderManager
  • switch to the currently working provider, i.e. the kde-look.org one
  • deal with non-const methods of Provider by copying it locally
  • use the different API of jobs
  • manually load the avatars (always with KIO), since Attica does not do that

Sadly, there is no kde/opendesktop provider that seems to provide
information on users at this time, so most of this is not tested much.
(But then, for the same reason the old code is not usable either.)

Test Plan

Builds fine

Diff Detail

Repository
R181 Amarok
Branch
use-system-attica (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
pino created this revision.May 28 2018, 8:56 PM
Restricted Application added a subscriber: amarok-devel. · View Herald TranscriptMay 28 2018, 8:56 PM
pino requested review of this revision.May 28 2018, 8:56 PM
pino added a comment.May 28 2018, 8:57 PM

Out-of-commit annotation: the code in src/aboutdialog/libattica-ocsclient/ will be removed in a followup commit after this patch is in.

pino updated this revision to Diff 35546.Jun 4 2018, 6:07 PM

Fix a connection to Attica::ProviderManager

heikobecker accepted this revision as: heikobecker.Jun 7 2018, 7:10 AM
This revision is now accepted and ready to land.Jun 7 2018, 7:10 AM
pino closed this revision.Jun 7 2018, 10:34 AM