Differential D13173

Add 404 page and blacklist it from showing on search results
AbandonedPublic
Actions

Authored by scottpetrovic on May 28 2018, 4:01 PM.

Details

Reviewers
woltherav
Summary

This adds a 404 page that can be translated.

It also overrides the search results so it will block the 404 page from being displayed

Test Plan

just built the english version. Did a search on "file not found". 404 page did not come back in search results. typed the 404 page in manually and it does actually exist.

Diff Detail

Repository
R184 Documentation Website (docs.kde.org)
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic created this revision.May 28 2018, 4:01 PM
Restricted Application added a project: Documentation. · View Herald TranscriptMay 28 2018, 4:01 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
scottpetrovic requested review of this revision.May 28 2018, 4:01 PM
ltoscano added a subscriber: ltoscano.May 28 2018, 4:26 PM

The repository is not docs.kde.org - did you use arcanist and it assigned the wrong repository?

woltherav added a comment.May 28 2018, 6:04 PM

Scott, you will need to resumit this because the whole diff is now against the wrong repository. I made the same mistake easier today.

woltherav requested changes to this revision.May 28 2018, 6:04 PM
This revision now requires changes to proceed.May 28 2018, 6:04 PM
scottpetrovic abandoned this revision.May 29 2018, 1:51 AM

crap... I will try again. closing this. sorry

Revision Contents
Changeset List

PathPackages
M404.rst (2 lines)
Mtheme/static/searchtools.js (593 lines)

Diff 35033

View Options

404.rst

Loading...
View Options

theme/static/searchtools.js

Loading...