Differential D13158

Fix i18n issues in Phabricator Plugin
ClosedPublic
Actions

Authored by nicolasfella on May 27 2018, 5:06 PM.

Details

Reviewers
apol
Commits
R495:e052c9e88fd1: Fix i18n issues in Phabricator Plugin
Summary

When the diffs combo box is empty i18n reports issues. This is a quick and dirty fix.

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 27 2018, 5:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 27 2018, 5:06 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.May 27 2018, 5:06 PM
nicolasfella edited the summary of this revision. (Show Details)May 27 2018, 5:14 PM
apol accepted this revision.May 27 2018, 10:10 PM
apol added inline comments.
src/plugins/phabricator/phabricatorplugin_config.qml
125 ↗(On Diff #34984)

Change to i18n("Summary of the update t %1:", updateDR), without .arg().

This revision is now accepted and ready to land.May 27 2018, 10:10 PM
Closed by commit R495:e052c9e88fd1: Fix i18n issues in Phabricator Plugin (authored by nicolasfella). · Explain WhyMay 27 2018, 10:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35004

View Options

src/plugins/phabricator/phabricatorplugin_config.qml

Loading...