Differential D13129

Show asterisk by modified filenames
ClosedPublic
Actions

Authored by rizzitello on May 26 2018, 4:17 AM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Commits
R231:535f6b312173: Show asterisk by modified filenames
R231:0c87d782ed3b: Show asterisk by modified filenames Signed-off-by: Chris Rizzitello…
Summary

Show an asterisk (*) by the file name if its been modified . remove it if its been unmodified

Needs D13126 to work correctly

Diff Detail

Repository
R231 Atelier
Branch
showModified
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.May 26 2018, 4:17 AM
rizzitello created this revision.
rizzitello retitled this revision from Show astrick by modified filenames Signed-off-by: Chris Rizzitello <rizzitello@kde.org> to Show asterisk by modified filenames.May 26 2018, 4:18 AM
rizzitello edited the summary of this revision. (Show Details)
rizzitello added reviewers: tcanabrava, patrickelectric, laysrodrigues.
rizzitello added a project: Atelier: General Development.
rizzitello added a subscriber: Atelier: General Development.
rizzitello updated this revision to Diff 34902.May 26 2018, 4:19 AM
  • typo fix
rizzitello edited the summary of this revision. (Show Details)May 26 2018, 4:23 AM
patrickelectric added inline comments.May 26 2018, 12:27 PM
src/widgets/gcodeeditorwidget.cpp
62

if the name of my file is "gcode.gcode*" ?

rizzitello marked an inline comment as done.May 26 2018, 1:33 PM
rizzitello added inline comments.
src/widgets/gcodeeditorwidget.cpp
62

Your tab will be gcode.gcode** when modified. The asterisk is not a valid filename character on windows and most *nix users dont' use it either. I went with the lone asterisk since it is used by everyone its almost universal.

rizzitello updated this revision to Diff 34920.May 26 2018, 2:33 PM
rizzitello marked an inline comment as done.
  • Simplify code.
rizzitello marked an inline comment as done.May 26 2018, 2:33 PM
patrickelectric accepted this revision.May 26 2018, 3:51 PM
This revision is now accepted and ready to land.May 26 2018, 3:51 PM
rizzitello closed this revision.May 27 2018, 1:57 AM

Revision Contents
Changeset List

PathPackages
Msrc/widgets/gcodeeditorwidget.cpp (8 lines)

Diff 34947

View Options

src/widgets/gcodeeditorwidget.cpp

Loading...