Differential D13117

Don't set custom domain filter rules
ClosedPublic
Actions

Authored by aleksanderm on May 25 2018, 4:08 PM.

Details

Reviewers
jgrulich
broulik
Group Reviewers
Frameworks
Commits
R281:54cc344aa659: Don't set custom domain filter rules
Summary

The library shouldn't set custom filter rules, it's a task of the app
using the library to enable or disable them.

Diff Detail

Repository
R281 ModemManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aleksanderm created this revision.May 25 2018, 4:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 25 2018, 4:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aleksanderm requested review of this revision.May 25 2018, 4:08 PM
jgrulich accepted this revision.May 26 2018, 7:40 AM
This revision is now accepted and ready to land.May 26 2018, 7:40 AM
aleksanderm added a comment.Jun 11 2018, 5:01 PM

Any ETA to land this change?

Closed by commit R281:54cc344aa659: Don't set custom domain filter rules (authored by aleksanderm, committed by jgrulich). · Explain WhyJun 12 2018, 8:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/manager.cpp (3 lines)

Diff 36036

View Options

src/manager.cpp

Loading...