do not use buffered file IO
ClosedPublic
Actions

Authored by dakon on May 24 2018, 6:05 PM.

Details

Reviewers

Commits

R107:fcbcf0f1bdfa: do not use buffered file IO

Summary

This is not necessary here. Additionally we can use O_CLOEXEC to make sure the file descriptors are not leaked by accident.

Repository

R107 KWallet PAM Integration

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

dakon requested review of this revision.May 24 2018, 6:05 PM

have you tried this? because i have just tried it and it failed.

Aren't you missing a O_CREAT ?

aacid requested changes to this revision.Oct 8 2018, 8:56 PM

This revision now requires changes to proceed.Oct 8 2018, 8:56 PM

O_CREAT was missing, as well as the file mode. O_CLOEXEC is available for a long time, there should be no need for the compat define.

Please make me const-happy before commiting :)

This revision is now accepted and ready to land.Oct 25 2018, 10:30 PM

pam_kwallet.c
696	While this is "just an int", my personal taste is very much against using const on a file descriptor as this is not how this really works. I don't know.
704	ACK

pam_kwallet.c
696	It is how it really works. Think of as a handle value, you're promising not to assign that handle value to point somewhere else, not that you won't change the value it points to. Why i want this const? Because when you see that you can be sure that the rest of the file there's no other fd = open() or similar, and thus you're sure that the rest of the operations in this function that use fd are over "path".

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			pam_kwallet.c (28 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	34833			May 24 2018, 6:03 PM	★	★
Diff 2	43538			Oct 13 2018, 12:19 PM	★	★
Diff 3	44535	45c0f6d	R107:fcbcf0f1bdfab2597b4e2844688c53f40f05b59c	Oct 31 2018, 11:34 AM	★	★