Differential D13085

[RadioButton] Rename "control" to "controlRoot"
ClosedPublic
Actions

Authored by broulik on May 24 2018, 8:39 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R858:9e864e8059c1: [RadioButton] Rename "control" to "controlRoot"
Summary

This makes it consistent with CheckBox and also fixes the focus indicator.
Also make the rest of the code identical to CheckBox

Test Plan
  • Compared the two files, were identical now except for the indicator component name and the onTriggered action
  • Focus indicator on RadioButton works again
  • Text color was still correct

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 24 2018, 8:39 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 24 2018, 8:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 24 2018, 8:39 AM
mart accepted this revision.May 24 2018, 9:54 AM
This revision is now accepted and ready to land.May 24 2018, 9:54 AM
Closed by commit R858:9e864e8059c1: [RadioButton] Rename "control" to "controlRoot" (authored by broulik). · Explain WhyMay 24 2018, 10:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/RadioButton.qml (30 lines)

Diff 34793

View Options

org.kde.desktop/RadioButton.qml

Loading...