Differential D13036

piano_composition, add contexts for translators.
ClosedPublic
Actions

Authored by amankumargupta on May 22 2018, 10:08 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8770: piano_composition, add contexts for translators.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 22 2018, 10:08 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
jjazeix accepted this revision.May 22 2018, 3:50 PM
jjazeix added a subscriber: jjazeix.
jjazeix added inline comments.
src/activities/piano_composition/MultipleStaff.qml
108

!foundNote here too

src/activities/piano_composition/Piano.qml
56

the order should be the same but better copy/paste the comment in case the translator does not want to look for the annotation

This revision is now accepted and ready to land.May 22 2018, 3:50 PM
amankumargupta added inline comments.May 22 2018, 3:53 PM
src/activities/piano_composition/MultipleStaff.qml
108

It won't be needed as we break this loop when a note is found.

src/activities/piano_composition/Piano.qml
56

Will copy/paste the comment before committing.

Revision Contents
Changeset List

Diff 34632

View Options

src/activities/piano_composition/MultipleStaff.qml

Loading...
View Options

src/activities/piano_composition/NoteNotations.js

Loading...
View Options

src/activities/piano_composition/Piano.qml

Loading...