Fix countryToISO() returning the local country for unknown country names
ClosedPublic
Actions

Authored by vkrause on May 20 2018, 3:10 PM.

Details

Reviewers

kde-pim
winterz

Commits

R174:9b7eaba53449: Fix countryToISO() returning the local country for unknown country names

Summary

Better to show nothing rather than something random when the country name
is not recognized or contains a typo. More importantly, this actually
enables the caller to handle this case.

Diff Detail

Repository

R174 KContacts

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

vkrause created this revision.May 20 2018, 3:10 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 20 2018, 3:10 PM

vkrause requested review of this revision.May 20 2018, 3:10 PM

I guess this QLocale::bcp47Name() is useless in this situation.

Right, we don't want a "dash-separated language, script and country (and possibly other BCP47 fields) of this locale as a string."

ship it

This revision is now accepted and ready to land.May 20 2018, 3:25 PM

Closed by commit R174:9b7eaba53449: Fix countryToISO() returning the local country for unknown country names (authored by vkrause). · Explain WhyMay 21 2018, 8:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/addresstest.h (1 line)
M			autotests/addresstest.cpp (10 lines)
M			src/address.h (6 lines)
M			src/address.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	34535	d02178f		May 20 2018, 3:10 PM	★	★
Diff 2	34566	a5d21b3	R174:9b7eaba5344954f55aaf26cb796565ee6253c8fd	May 21 2018, 8:58 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
b9891313fe9c	1b9a4820ed33	d02178f60ecb	Volker Krause	Fix countryToISO() returning the local country for unknown country names (Show More…)	May 20 2018, 3:09 PM