Differential D12973

Workspace KCM Redesign Using Kirigami
ClosedPublic
Actions

Authored by furkantokac on May 18 2018, 10:31 PM.

Details

Reviewers
ngraham
romangg
Group Reviewers
Plasma
Commits
R119:78cd8bb31ea3: Workspace KCM Redesign Using Kirigami
R119:2b5809b1d5ba: Workspace KCM Redesign Using Kirigami
Summary

Workspace KCM is redesigned by using Kirigami. Functionality is same. Recommendations are welcome.

New design:

Old design:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
furkantokac created this revision.May 18 2018, 10:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 18 2018, 10:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
furkantokac requested review of this revision.May 18 2018, 10:31 PM
furkantokac edited the summary of this revision. (Show Details)May 18 2018, 10:33 PM
furkantokac edited the summary of this revision. (Show Details)
furkantokac edited the summary of this revision. (Show Details)
furkantokac added reviewers: ngraham, romangg.
furkantokac edited the summary of this revision. (Show Details)May 18 2018, 10:46 PM
furkantokac edited the summary of this revision. (Show Details)
furkantokac updated this revision to Diff 34459.May 18 2018, 11:15 PM

Workspace KCM is redesigned by using Kirigami.

furkantokac retitled this revision from Workspace KCM Redesign and Formatting Improvement to Workspace KCM Redesign Using Kirigami.May 18 2018, 11:16 PM
furkantokac edited the summary of this revision. (Show Details)
ngraham accepted this revision.May 19 2018, 1:50 AM

Nicely done! Code and visual changes look good to me. Tested it out and everything still works. Just two little comment formatting nitpicks, then this is good to go from my perspective! (wait for other reviews too before landing, please)

kcms/workspaceoptions/package/contents/ui/main.qml
32–39

"Visual behavior settings"

57–60

"Click behavior settings"

This revision is now accepted and ready to land.May 19 2018, 1:50 AM
furkantokac updated this revision to Diff 34500.May 20 2018, 1:59 AM

Comment correction.

furkantokac edited the summary of this revision. (Show Details)May 21 2018, 7:46 AM
Closed by commit R119:78cd8bb31ea3: Workspace KCM Redesign Using Kirigami (authored by furkantokac). · Explain WhyMay 21 2018, 10:36 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.May 22 2018, 3:59 AM

Looks gorgeous!

Revision Contents
Changeset List

Diff 34616

View Options

kcms/workspaceoptions/package/contents/ui/main.qml

Loading...