Removed some calls that the only thing it did was to forward
with the same arguments the call to another object, call the
object directly
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:f084dbfbeeb4: Remove unnecessary forward-calls
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/Application.cpp | ||
---|---|---|
433 ↗ | (On Diff #34442) | I can see that in MainWindow.h and MainWindow.cpp this pattern is doing more harm than good. However, it seems to make sense from client-code perspective. Hence, in these two specific cases (this line and line 437), you could create methods such as showTabBar and hideTabBar. |
src/Application.cpp | ||
---|---|---|
433 ↗ | (On Diff #34442) | That's not really possible currently as the tabbar is unrelated to the window, what to do in the case of two tabbars, etc. |