Remove unnecessary forward-calls
ClosedPublic

Authored by tcanabrava on May 18 2018, 4:15 PM.

Details

Summary

Removed some calls that the only thing it did was to forward
with the same arguments the call to another object, call the
object directly

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.May 18 2018, 4:15 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 18 2018, 4:15 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.May 18 2018, 4:15 PM
pedroarthurp added inline comments.
src/Application.cpp
433 ↗(On Diff #34442)

I can see that in MainWindow.h and MainWindow.cpp this pattern is doing more harm than good. However, it seems to make sense from client-code perspective. Hence, in these two specific cases (this line and line 437), you could create methods such as showTabBar and hideTabBar.

tcanabrava added inline comments.May 23 2018, 7:29 AM
src/Application.cpp
433 ↗(On Diff #34442)

That's not really possible currently as the tabbar is unrelated to the window, what to do in the case of two tabbars, etc.
in a following patch I plan to ditch the tabbar management code and replace with something more sane.

hindenburg accepted this revision.Jun 10 2018, 12:11 AM
hindenburg retitled this revision from Remove unecessary forward-calls to Remove unnecessary forward-calls.
This revision is now accepted and ready to land.Jun 10 2018, 12:12 AM
This revision was automatically updated to reflect the committed changes.