Fix word selection mode
ClosedPublic

Authored by mglb on May 17 2018, 12:17 AM.

Details

Test Plan
  • run printf '%.0skonsole ' $(seq 200) to generate some words
  • double click on the beginning of any word
  • move mouse pointer right/bottom to extend selection

Expected result: the selection should extend word by word, with the
selection end being on the left or right side of a word located under
pointer

Actual result: right selection end extends character by character and
is located at fixed offset from the pointer

Diff Detail

Repository
R319 Konsole
Branch
arc/Fix-word-selection-mode (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
mglb created this revision.May 17 2018, 12:17 AM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 17 2018, 12:17 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
mglb requested review of this revision.May 17 2018, 12:17 AM
mglb updated this revision to Diff 34404.May 18 2018, 2:16 AM

Fix the fix

+1, this fixes the bug for me! No regressions seem in single-click-drag or triple-click drag.

Did you happen to find any Bugzilla tickets that this fixes, or was the issue never reported?

This revision is now accepted and ready to land.May 18 2018, 12:05 PM
mglb added a comment.May 18 2018, 7:54 PM

Well... the bug was introduced by me in 17cb78cee147. I didn't see anything related on mailing list since then. Those two bugs are not related.

hindenburg closed this revision.May 21 2018, 9:12 PM

commit f24aa818f97b6bebdcc4ce62c927994232b6f282

for some reason it didn't update this ticket