transferjob new connect syntax
AcceptedPublic
Actions

Authored by jtamate on May 14 2018, 7:17 AM.

Details

Reviewers

Group Reviewers

Summary

Use the new connect syntax.
A new QMetaObject::Connection is introduced to disconnect the signal connected in the constructor.

Test Plan

copy from compressed file

Diff Detail

Repository

R241 KIO

Lint

Lint Skipped

Unit

Unit Tests Skipped

jtamate created this revision.May 14 2018, 7:17 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 14 2018, 7:17 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

jtamate requested review of this revision.May 14 2018, 7:17 AM

dfaure accepted this revision.Jul 8 2018, 10:47 PM

This revision is now accepted and ready to land.Jul 8 2018, 10:47 PM

Sorry, I should have updated this revision earlier.
There are two methods than can not be removed from the Q_PRIVATE_SLOT definitions, otherwise the invokeMethod will fail.

if (m_closedBeforeStart) {
    QMetaObject::invokeMethod(q, "slotIODeviceClosed", Qt::QueuedConnection);
} else if (m_outgoingDataSource->bytesAvailable() > 0) {
    QMetaObject::invokeMethod(q, "slotDataReqFromDevice", Qt::QueuedConnection);
}