Details
- Reviewers
rkflx - Group Reviewers
Gwenview - Commits
- R260:e8e6d40b3d59: Cleanup code for finishing undo/redo of image operations
- Use different image operations to edit one or more image(s)
- Check that undo/redo behaviour did not change
Diff Detail
- Repository
- R260 Gwenview
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
In terms of the Phabricator changes - what's the way for Gwenview?
Are there any effects when using #gwenview as reviewer?
Thanks ;) Having the change in a separate Diff really makes for a quick review.
After enabling redo in D12105 this is not needed anymore
"This" is a bit ambiguous. Surely you don't mean the timer, but splitting the code out into a separate function?
As far as I understood, the change only affected Herald rules (which we don't have) and forwarding to mailinglists (which we don't do, and which I'd find quite questionable).
As long as nobody of us gets too annoyed with our current way of working, I'd say we simply carry on as usual (but I believe there are also more fine-grained filtering options available using Phab's mail headers, should the need arise to distinguish between subscriber/reviewer notifications and bulk Gwenview mail).
As far as I understood, the change only affected Herald rules (which we don't have) and forwarding to mailinglists (which we don't do, and which I'd find quite questionable).
As long as nobody of us gets too annoyed with our current way of working, I'd say we simply carry on as usual (but I believe there are also more fine-grained filtering options available using Phab's mail headers, should the need arise to distinguish between subscriber/reviewer notifications and bulk Gwenview mail).
With a small team, I like getting notifications about all activity, so I think carry on.